This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] Fix info frame's saved registers output

Eli Zaretskii wrote: 
Date: Fri, 29 Oct 2004 10:02:09 -0400
From: Andrew Cagney <cagney@gnu.org>

2004-10-27 Andrew Cagney <cagney@gnu.org>

	* trad-frame.c (trad_frame_get_prev_register): Use
	frame_unwind_register instead of frame_register_unwind



Isn't it confusing to have 2 different functions whose names are just
permutations of the same words?  How can a GDB hacker know what is the
difference between frame_register_unwind and frame_unwind_register,
without reading the sources?

True, wan't to rename it? At the top of frame.h there's a blurb proposed naming convention.

Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]