This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] Convert COERCE_* to functions


> Date: Thu, 11 Nov 2004 11:36:57 -0500
> From: Andrew Cagney <cagney@gnu.org>
> Cc: gdb-patches@sources.redhat.com
> 
> > 1) Can you tell the reason for these changes?
> > 
> > 2) Personally, I think that
> > 
> >      foo = foobar (foo);
> > 
> >    is not a good style of C programming.
> 
> opaque `struct value'
> http://sources.redhat.com/ml/gdb/2004-11/msg00010.html

Thanks.  Perhaps it would help in the future to post the URL with the
patch.

> Converting a macro to a function has for a long time been considered 
> obvious.

I don't think it's obvious, but if I'm the only one, let's codify that
where we say what falls under the ``obvious'' rule.

What about my second comment? isn't it better to make the functions
void and let them modify the argument?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]