This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Relative and absolute paths in link_map


On Thu, 17 Feb 2005 18:20:43 +0300
"Levchenko, Vasily V" <vasily.v.levchenko@intel.com> wrote:

> This is a patch corrects comparing of the shared object names which
> could be relative and absolute.
> Situation:
> 	To get tls-variable from shared library.

Hi Vasily,

Thanks for your patch!

In the future, please send some sort of context diff, that is, patches
generated either with "diff -u" or "diff -C".  (I also like it when the
"-p" switch is used.)

I have read your patch and understand what it is doing, but before
putting your change in, I'd first like to understand why it's necessary.
Could you offer a bit more explanation about why it is needed?  Do you
happen to have a small test case?

Your patch is small enough that it can likely go in without an FSF
copyright assignment.  You should know, however, that most patches
require some sort of copyright assignment.  If you think you might
make further contributions to GDB in the future, you should make the
proper legal arrangements.  If this is something that you're
interested in, let me know, and I will ask to have the necessary
documents sent to you.

Again, I thank you for your patch, and hope that you can provide me
with the some sort of test case or at least a description of the
scenario in which your patch is needed.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]