This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING PING] Deal with intermixed 32-bit and 64-bit DWARF sections]


M.M. Kettenis writes:
 > Daniel Jacobowitz <drow@false.org> wrote: 
 > 
 > > On Tue, Jan 25, 2005 at 10:06:53PM +0100, Mark Kettenis wrote:
 > > > [ Second ping ]
 > > > 
 > > > [ Elena, I never saw a reaction of you on this.  Could you please
 > > >   review it? ]
 > > > 
 > > > Date: Wed, 10 Nov 2004 22:28:46 +0100 (CET)
 > > > From: Mark Kettenis <kettenis@gnu.org>
 > > > 
 > > > Currently GDB crashes hard when we encounter both 32-bit anbd 64-bit
 > > > DWARF sections within the same compilation unit.  Keeping the mantra
 > > > "Be liberal what you accept, but complain loudly", this patch fixes
 > > > that.
 > > 
 > > Mark,
 > > 
 > > Did you mean to check in the test case without the fix?  Not only does
 > > it fail, it divides by zero, triggering the "infinite SIGFPE" bug
 > > elsewhere reported in our bug database, and adding about ten minutes to
 > > all of my testsuite runs.
 > 
 > Sorry 'bout that.  But Elena didn't review it yet.  Fix is sitting at
 > home so I'll probably (ab)use my global maintainer rights to check this
 > in when I get back this weekend.
 > 

I asked Mark, in response to a private e-mail, to provide a testcase
as a necessary condition for his patch to go in.  No need for
threats.

I fixed the patch for internationalization and changes to an ifdeffed
out function and checked it in.






Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]