This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] test for altivec h/w on PowerPC


Daniel,

Thanks a lot for your speedy review!

I didn't know Janis wrote it, she didn't say so when she showed it to me.
(Her cube is right next to mine: we are in the same group)

On Tuesday 01 March 2005 15:28, Daniel Jacobowitz wrote:
> On Tue, Mar 01, 2005 at 03:19:39PM -0800, Paul Gilliam wrote:
> > Ok to commit?
>
> Not quite.
>
> - You've missed a changelog entry.
>
Oops.  Got it this time.

> - You're running a test on the build system instead of the target
> system.
>
Ok.  

> - This code is based on Janis's check_vmx_hw_available from GCC, so you
> might want to give credit.  Incidentally, the original version runs the
> test on $target...
Ok.

I also added a line to delete the exe file after we run it.

Ok to commit?

-=# Paul Gilliam #=-


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]