This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jim Blandy <jimb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 12 Mar 2005 01:05:06 -0800
- Subject: Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O
- References: <vt2is4c77ng.fsf@zenia.home>
Jim,
> 2005-02-28 Jim Blandy <jimb@redhat.com>
>
> Avoid warnings due to the use of -Wuninitialized without -O.
> * configure.ac (build_warnings): Include -Wuninitialized only if
> CFLAGS is unset at configure time, or CFLAGS is set and includes
> some -O option other than -O0.
> * configure: Regenerated.
I think there is a slight problem that broke the build with non-GNU
bourne shells. We have a build failure on our solaris 2.8 machine,
for instance. Here is what I think the problem is:
> + # GCC supports -Wuninitialized only with -O or -On, n != 0.
> + if test x${CFLAGS+set} == xset; then
^^
I think the "==" should be "=", no? That's what "man test" documents.
But I've never been a shell guru...
--
Joel