This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Fix problem fetching/setting FSR register (IRIX)
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: brobecker at adacore dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 26 Mar 2005 09:02:26 +0100 (CET)
- Subject: Re: [RFA] Fix problem fetching/setting FSR register (IRIX)
- References: <20050326004308.GH2545@adacore.com>
Date: Fri, 25 Mar 2005 16:43:08 -0800
From: Joel Brobecker <brobecker@adacore.com>
Hello,
The attached patch fixes the problem reported at:
http://sources.redhat.com/ml/gdb-patches/2005-03/msg00294.html
The explaination of the actual problem is detailed at:
http://sources.redhat.com/ml/gdb-patches/2005-03/msg00309.html
I have also added some comments in the code, and included Mark's
comments.
2005-03-25 Joel Brobecker <brobecker@adacore.com>
* irix5-nat.c (supply_fpregset): Fix bug that caused the FSR
register value to be incorrectly written in the regcache.
(fill_fpregset): Fix bug that caused the FSR register value
to be incorrectly read from the regcache.
Fixes [E223-028].
Tested on mips-irix. No regression. OK to apply?
Oh, my message was sort of intended as approval. But now that you
asked again, there's one little nit: what's that funny E223-028. If
it is what I think it is, then I'm not sure if we should add bug ID's
from a non-public bug database to our ChangeLog.
(I will submit a testcase for this asap)
A somewhat general MIPS floating-point test would be great ;-).
Mark