This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: respect -k or its absence when building sim subdirs


Daniel Jacobowitz <drow@false.org> writes:
> On Wed, Apr 13, 2005 at 12:32:23PM -0500, Jim Blandy wrote:
> > 
> > Overkill, probably.  I just hate this kind of stuff.
> > 
> > 2005-04-13  Jim Blandy  <jimb@redhat.com>
> > 
> > 	Fix -k handling when looping over subdirectories.
> > 	* for-subdirs.sh: New script.
> > 	* Makefile.in (all clean mostlyclean distclean maintainer-clean
> > 	realclean install): Use it to loop over subdirectories.
> 
> Wow... this really is overkill, and I'm not sure that the quoting does
> what you want it to.  Can't you do this in make more straightforwardly?
> I know you can in GNU make, anyway.

Can you suggest a strategy?  Whatever you do, you have to replicate it
in each of those targets.  If it's not pretty trivial, I don't want to
write it out every time; it belongs in a "function", which, in this
world, is a script.

After I posted, I realized the quoting could be simplified to:

  clean mostlyclean:
  	@rootme=`pwd` ; export rootme ; \
! 	$(SHELL) $(srcdir)/for-subdirs.sh \
! 		"$(MAKEFLAGS)" '$(MAKE) $(FLAGS_TO_PASS) $@' $(SUBDIRS)
  

Where else were you worried about the quoting?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]