This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Support Windows in event-loop.c

On Mon, Apr 25, 2005 at 04:19:36PM -0700, Mark Mitchell wrote:
>>The patch was ok with me, too, but it seems like you should be checking
>>the bounds of the handles array just in the off chance that readfds is >
>>63.  I know that it is probably vanishingly unlikely that this could ever
>>occur but it still seems like good practice nonetheless.
>
>OK.  May I consider a patch to add the appropriate gdb_assert obvious?

Sure.

cgf
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]