This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] Crash on windows hosts
On Thu, Apr 28, 2005 at 09:21:49AM -0400, Daniel Jacobowitz wrote:
>On Wed, Apr 27, 2005 at 11:36:12PM -0400, Christopher Faylor wrote:
>> I didn't look closely to see why Windows would return a NULL when other
>> systems would not but given that it is obviously possible for
>> serial_fdopen to return NULL, it seems like this patch is correct.
>
>I presume the reason is because there's no serial port named
>"hardwire" on Windows - only Unix-like systems and GO32 (DOS).
So, that points out a generic problem lurking behind this one. The
Windows part of gdb should implement a "hardwire" serial port. I guess
I'll put that on my todo list.
Btw, there is one other use of serial_fdopen which uses NULL protection
so, again, I'd say this is a trivial fix which should be checked in.
cgf