This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [commit] Use bfd_byte in value.h
On Thu, Apr 28, 2005 at 09:19:20PM +0200, Mark Kettenis wrote:
> Date: Thu, 28 Apr 2005 12:25:52 -0400
> From: Andrew Cagney <cagney@gnu.org>
>
> This changes value.h to use bfd_byte more consistently. When trying to
> fix the signed (string) VS unsigned (buffer) pointer warnings you very
> quickly run into these interfaces.
>
> Hacking on a mac again?
>
> Anyway, to place my previous comments about this issue in a context,
> this really is analogous to strxxx() versus memxxx(). This gives a
> clue to what the proper pointer type for these buffers is: `void *'.
> I guess GDB's K&R history really shows here. Does converting to `void
> *' require more effort than simply replacing things with `bfd_byte *'?
Probably, since you can no longer do arithmetic on them.
--
Daniel Jacobowitz
CodeSourcery, LLC