Re: Committed, MAINTAINERS, sim/cris: Fix make -j race and mark cris-elf as non-broken, cp-name-parser.y

[Daniel Jacobowitz <drow at false dot org>]

Please don't commit unrelated changes together in the future.

On Sat, May 28, 2005 at 10:58:31AM +0200, Hans-Peter Nilsson wrote:
> cc1: warnings being treated as errors
> cp-name-parser.y: In function 'parse_escape':
> cp-name-parser.y:1443: warning: 'target_char' may be used
> uninitialized in this function
> 
> in the gdb directory.  I looked at that problem and concluded
> the patch to cp-name-parser.y as an obvious fix.  The warning
> came from gcc-4.0.0-2 and looks correct; the c_parse_backslash
> is a static function and apparently the code *has* that problem;
> it's not a false positive.  It takes two looks.  Then I ran into:

Maybe it takes three?  Your patch is incorrect, since it is covering up
a real problem.  It ought to be "return c".

> cc1: warnings being treated as errors
> /home/hp/simj/src/gdb/source.c: In function '_initialize_source':
> /home/hp/simj/src/gdb/source.c:1649: warning: pointer targets in
> passing argument 3 of 'add_setshow_uinteger_cmd' differ in
> signedness
> 
> but this time, I give up and just blindly commit what I
> have<rant> as that was obviously the level of testing that was
> done when the change exposing that warning was committed</rant>.

Hello?  Please think for a moment or read the beginning of the gdb_byte
discussion.  Most of us have not started using GCC 4.0.0 yet, and even
Andrew hadn't in February.  Earlier versions didn't produce that
warning.

It's quite well known by now that GDB does not build using GCC 4.0.0
and -Werror.

-- 
Daniel Jacobowitz
CodeSourcery, LLC