Re: [RFC]: Add test for verifying the fix to the SEGV error whenprinting F77 array element

[Wu Zhou <woodzltc at cn dot ibm dot com>]

Hi Daniel,

Thanks a lot for pointing out these problems.  The re-worked patch is as 
follows.  I had tested it on g77-3.2.3 (on Fedora Core 4 for i386), 
g77-3.3.3 and g77-3.4.3 (on SLES9 and RHEL4 for ppc64).  Please review and 
comment.  Thanks!

array-element.f
====================================================
*** /dev/null	2005-06-14 07:40:50.585435768 +0800
--- gdb.fortran/array-element.f	2005-06-15 11:30:20.000000000 +0800
***************
*** 0 ****
--- 1,32 ----
+ c Copyright 2005 Free Software Foundation, Inc.
+ 
+ c This program is free software; you can redistribute it and/or modify
+ c it under the terms of the GNU General Public License as published by
+ c the Free Software Foundation; either version 2 of the License, or
+ c (at your option) any later version.
+ c 
+ c This program is distributed in the hope that it will be useful,
+ c but WITHOUT ANY WARRANTY; without even the implied warranty of
+ c MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ c GNU General Public License for more details.
+ c 
+ c You should have received a copy of the GNU General Public License
+ c along with this program; if not, write to the Free Software
+ c Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  
+ 
+ c This file is the F77 source for array-element.exp.  It was written
+ c by Wu Zhou. (woodzltc@cn.ibm.com)
+ 
+         dimension a(10)
+         call sub(a,10)
+         write(*,*) a
+         stop
+         end
+ 
+         subroutine sub(a,n)
+         dimension a(n)
+         do 100 i = 1, n 
+           a(i) = i
+ 100     continue
+         return
+         end

array-element.exp
=====================================================
*** /dev/null	2005-06-14 07:40:50.585435768 +0800
--- gdb.fortran/array-element.exp	2005-06-15 11:32:26.000000000 +0800
***************
*** 0 ****
--- 1,60 ----
+ # Copyright 2005 Free Software Foundation, Inc.
+ 
+ # This program is free software; you can redistribute it and/or modify
+ # it under the terms of the GNU General Public License as published by
+ # the Free Software Foundation; either version 2 of the License, or
+ # (at your option) any later version.
+ # 
+ # This program is distributed in the hope that it will be useful,
+ # but WITHOUT ANY WARRANTY; without even the implied warranty of
+ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ # GNU General Public License for more details.
+ # 
+ # You should have received a copy of the GNU General Public License
+ # along with this program; if not, write to the Free Software
+ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  
+ 
+ # This file was written by Wu Zhou. (woodzltc@cn.ibm.com)
+ 
+ # This file is part of the gdb testsuite.  It contains test for printing
+ # the elements of an array which is passed as pointer to a subroutine.
+ 
+ if $tracelevel then {
+ 	strace $tracelevel
+ }
+ 
+ set testfile "array-element"
+ set srcfile ${testfile}.f
+ set binfile ${objdir}/${subdir}/${testfile}
+ 
+ if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug f77}] != "" } {
+     untested "Couldn't compile ${srcfile}"
+     return -1
+ }
+ 
+ gdb_exit
+ gdb_start
+ gdb_reinitialize_dir $srcdir/$subdir
+ gdb_load ${binfile}
+ 
+ if ![runto sub_] then {
+     perror "couldn't run to breakpoint sub_"
+     continue
+ }
+ 
+ set bp_location [gdb_get_line_number "continue"]
+ gdb_test "break $bp_location" \
+     "Breakpoint.*at.* file .*$srcfile, line $bp_location\\." \
+     "breakpoint at continue"
+ 
+ # Run to continue for the first time and print a(1)
+ gdb_test "continue" \
+     "Continuing\\..*Breakpoint.*" \
+     "continue to breakpoint"
+ gdb_test "print a(1)" ".*1 = 1.*" "print the first element of array a"
+ 
+ # Run to continue for the second time and print a(2)
+ gdb_test "continue" \
+     "Continuing\\..*Breakpoint.*" \
+     "continue to breakpoint once again"
+ gdb_test "print a(2)" ".*2 = 2.*" "print the second element of array a"

Cheers
- Wu Zhou

> Thanks.  It does need some changes, but not big ones.
> 
> I'd appreciated it if you could provide new files as diffs.  The normal
> way to do this is by diffing them against /dev/null, with the
> appropriate relative path to the new file.  That way, I can save your
> message and apply it as a patch.
> 
> Let's use hyphens instead of underscores in file names; there's already
> a lot of hyphenated test cases.  So array-element.exp.
>