This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] mi-stack.exp


On Mon, Jun 20, 2005 at 12:57:34PM +1200, Nick Roberts wrote:
> 2005-06-20  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* gdb.mi/mi-stack.exp (test_stack_locals_listing): 
> 	Remove test for -stack-select-frame without arguments.
> 	(test_stack_frame_listing): 
> 	Add test for newly implemented command -stack-info-frame.

OK.  Please wrap it this way:

	* gdb.mi/mi-stack.exp (test_stack_locals_listing): Remove test for
	-stack-select-frame without arguments.
	(test_stack_frame_listing): Add test for newly implemented command
	-stack-info-frame.

> *** /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp.~1.15.~	2005-05-18 20:18:15.000000000 +1200
> --- /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp	2005-06-19 18:49:18.000000000 +1200

Could you see about submitting relative diffs?  It doesn't really
matter what they're relative _to_ - common is -p0 or -p1 to the top
directory whose ChangeLog you're touching.  But this is a bit awkward
to apply.

As an aside, if you don't mind, please check in patches all at once. 
When you check in each file separately with its own log message,
automated tools can't reconstruct the entire change.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]