This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] i386-tdep.c: Fix datatype

On Jun 23 22:54, Mark Kettenis wrote:
>    Date: Thu, 23 Jun 2005 18:36:37 +0200
>    From: Corinna Vinschen <vinschen@redhat.com>
> 
>    Hi,
> 
>    the below patch is just a minor tweak.  The stack pointer offset sp_offset
>    stored in struct i386_frame_cache is an offset, not an address.  It looks
>    more correct to define it as LONGEST, not as CORE_ADDR.  Especially since
>    sp_offset can contain positve and negative values.
> 
>    Corinna
> 
>    * i386-tdep.c (struct i386_frame_cache): Define sp_offset as LONGEST.
> 
> Aauming this compiles with -Werror (and I have no reason to suspect
> that it wouldn't, this is ok.

It compiles fine with -Werror, so I checked it in.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]