This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH RFA: Fix simulator handling of floating point absolute value
- From: Daniel Jacobowitz <drow at false dot org>
- To: Ian Lance Taylor <ian at airs dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 8 Jul 2005 10:00:59 -0400
- Subject: Re: PATCH RFA: Fix simulator handling of floating point absolute value
- References: <m3br5dx4ci.fsf@gossamer.airs.com>
On Thu, Jul 07, 2005 at 10:18:53PM -0700, Ian Lance Taylor wrote:
> The common simulator routine sim_fpu_abs is used by MIPS, MN10300,
> SH64, and perhaps some CGEN generated simulators (it is called by
> cgen-accfp.c). On most, and perhaps all, hardware, a floating point
> absolute value instruction simply clears the sign bit. However,
> sim_fpu_abs does not clear the sign bit when given a NaN. For MIPS,
> this causes the gcc test gcc.c-torture/execute/ieee/copysign1.c to
> fail.
>
> This patch changes sim_fpu_abs to always clear the sign bit of the
> argument. It does not otherwise change the behaviour. This, plus
> another patch I am about to sign, fixes the gcc copysign1 test for
> MIPS.
>
> OK for mainline?
I have no references for this concern, but could you check that this
change is appropriate for at least MN10300 and SH64, since they share
ths code?
--
Daniel Jacobowitz
CodeSourcery, LLC