This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
[Please keep me in the Cc: line, as I don't subscribe to gdb-patches] Hi Mark, Your patch to unconditionally include shared library code: Original patch - http://sources.redhat.com/ml/gdb-patches/2005-05/msg00043.html Respin that went in - http://sources.redhat.com/ml/gdb-patches/2005-05/msg00198.html ... appears to have borked cygwin. No criticism of yourself should be read into this fact: you did appeal for cygwin testing, and nobody stepped up to the plate, so I'm as much to mea culpa as anybody. Anyway, the problem is that win32-nat.c implements its own versions of the solib functions, and since your change, there is now a namespace clash over solib_address. I don't know if this is directly because of your patch, or some indirect knock-on from multi-arch work that has been ongoing; I think it is probably just because solib.o is in the COMMON_OBS now, but I haven't actually checked out and built an earlier cvs version to confirm my theory. The attached patch fixes the problem, at any rate for me. However: a) I haven't done before-and-after testsuite runs yet, because of course there was no way to build a 'before' version recently. b) It may or may not impact MinGW. I don't use MinGW and don't have an install or setup; I don't even know if MinGW can be a native gdb target, although I have this vague memory of having read posts here that say it doesn't currently support gdb, and I couldn't find it mentioned in src/gdb/config/i386/*. So this might or might not be an issue. c) I changed a whole bunch of function names that didn't clash. I find this nice and consistent, but others may feel differently about aesthetically-pleasing but non-essential changes being applied. So I would appreciate a bit of review (and preferably from someone who knows better than me what's going on in this corner of the world!). 2005-08-17 Dave Korn <dave.korn@artimi.com> * win32-nat.c (solib_address): Renamed from this... (win32_nat_solib_address): ...to this, to avoid clash with solib.c (child_solib_loaded_library_pathname, child_clear_solibs) (dll_symbol_command): Likewise renamed to.... (win32_nat_child_solib_loaded_library_pathname) (win32_nat_child_clear_solibs, win32_nat_dll_symbol_command): ...these, and all call sites adjusted. * config/i386/tm-cygwin.h (SOLIB_ADD, SOLIB_LOADED_LIBRARY_PATHNAME) (CLEAR_SOLIB, ADD_SHARED_SYMBOL_FILES, PC_SOLIB): Added 'win32_nat_' prefix to all symbols to match renamed functions in win32-nat.c. cheers, DaveK -- Can't think of a witty .sigline today....
Attachment:
gdb-cygwin-solib-problem-patch.diff
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |