This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Add some VAX floating point formats to floatformat.[ch]

From: Nick Clifton <nickc at redhat dot com>
To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
Cc: gdb-patches at sourceware dot org, binutils at sourceware dot org, gcc-patches at gcc dot org
Date: Mon, 22 Aug 2005 09:05:04 +0100
Subject: Re: [RFA] Add some VAX floating point formats to floatformat.[ch]
References: <200508212153.j7LLrJXJ006901@elgar.sibelius.xs4all.nl>

Hi Mark,

Index: include/ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* floatformat.h (enum floatformat_byteorders): Add
	floatformat_vax.
	(floatformat_vax_aingle, floatformat_vax_double): Declare.

No objections from binutils for this, although it is officially a GDB header file so make sure that you get agreement from them before committing your change. One point though:

+  /* VAX byte order.  */
+  floatformat_vax

I think that having a more descriptive comment for the VAX byte order would be helpful. eg describing the layout of 1.2345678e10 as is done with the other entries in this enum.

Cheers
  Nick

Follow-Ups:
- Re: [RFA] Add some VAX floating point formats to floatformat.[ch]
  - From: Mark Kettenis
- Re: [RFA] Add some VAX floating point formats to floatformat.[ch]
  - From: DJ Delorie

References:
- [RFA] Add some VAX floating point formats to floatformat.[ch]
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]