This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: contribute Renesas M32C sim
- From: Daniel Jacobowitz <drow at false dot org>
- To: Jim Blandy <jimb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 9 Oct 2005 16:15:00 -0400
- Subject: Re: RFA: contribute Renesas M32C sim
- References: <m3zmpl5a7a.fsf@alligator.red-bean.com>
There's a limit to how useful I can be reviewing sim patches, but I'll
try.
The most glaring omission is copyright notices. Not a single one.
Pretty much every file should have one. I assume the intention is to
assign this contribution to the FSF.
There seem to be a lot of too-long lines.
> + void
> + prefix (src_allowed, dest_allowed, index_bytewidth)
> + {
> + }
And what's that for?
--
Daniel Jacobowitz
CodeSourcery, LLC