This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: contribute Renesas M32C sim


There's a limit to how useful I can be reviewing sim patches, but I'll
try.

The most glaring omission is copyright notices.  Not a single one. 
Pretty much every file should have one.  I assume the intention is to
assign this contribution to the FSF.

There seem to be a lot of too-long lines.

> + void
> + prefix (src_allowed, dest_allowed, index_bytewidth)
> + {
> + }

And what's that for?

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]