This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix 'Undefined command' error message

From: Andrew STUBBS <andrew dot stubbs at st dot com>
To: Eli Zaretskii <eliz at gnu dot org>
Cc: gdb-patches at sources dot redhat dot com
Date: Wed, 16 Nov 2005 13:02:04 +0000
Subject: Re: [PATCH] Fix 'Undefined command' error message
References: <4379EC0A.3060601@st.com> <u1x1h93u5.fsf@gnu.org>

Eli Zaretskii wrote:

Why is there a need for testing *p to be non-zero?  AFAIK, isalnum is
well defined for a zero argument.

>

What is the reason for additional tests under TUI?

Is this for some kind of compatibility with XDB?

I do not know the answer to these questions, although I'm sure I could look into it. There are already two instances of this code in this file and each is implemented identically to the others.

The reason the code is like this here is because it must replicate the tests in lookup_cmd_1 if it is to give the right message. I do not know why lookup_cmd_1 is the way it is.

If you prefer I would be happy to pull out the code into a static function.

Andrew

Follow-Ups:
- Re: [PATCH] Fix 'Undefined command' error message
  - From: Eli Zaretskii

References:
- [PATCH] Fix 'Undefined command' error message
  - From: Andrew STUBBS
- Re: [PATCH] Fix 'Undefined command' error message
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]