This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Patch Ping]: Dont skip DW_TAG_member in load_partial_dies


Hi Elena,

I am now taking over some of Manoj's work on GDB.  He ever sent a patch to 
not skip DW_TAG_member in load_partial_dies.  The url is:

 http://sourceware.org/ml/gdb-patches/2005-02/msg00152.html

What is the status of this patch?  Do you have chance to review this?  

I also noticed that Daniel also posted a patch in 
http://sourceware.org/ml/gdb-patches/2005-04/msg00066.html, which also 
include this one.  That patch involve a little more situation.  But  this 
patch (attached below) is just one line one.  So I am thinking of that it 
might be easier to review this one, right?  Very happy to know what you 
are thinking of this patch.  Thanks a lot!

2005-02-15  Manoj Iyer  <manjo@austin.ibm.com>

	* dwarf2read.c (load_partial_dies): Save DIE with tag
	DW_TAG_member, generated by XLC when compiling C++ application.

diff -Naur ./old/src/gdb/dwarf2read.c ./new/src/gdb/dwarf2read.c
--- ./old/src/gdb/dwarf2read.c  2005-02-15 11:13:05.000000000 -0600
+++ ./new/src/gdb/dwarf2read.c  2005-02-22 10:24:08.000000000 -0600
@@ -5167,7 +5167,8 @@
          && abbrev->tag != DW_TAG_enumerator
          && abbrev->tag != DW_TAG_subprogram
          && abbrev->tag != DW_TAG_variable
-         && abbrev->tag != DW_TAG_namespace)
+         && abbrev->tag != DW_TAG_namespace
+         && abbrev->tag != DW_TAG_member)
        {
          /* Otherwise we skip to the next sibling, if any.  */
          info_ptr = skip_one_die (info_ptr + bytes_read, abbrev, cu);

Regards
- Wu Zhou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]