This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Fix compiler warnings in osabi.c
- From: Daniel Jacobowitz <drow at false dot org>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 10 Jan 2006 23:19:35 -0500
- Subject: Re: [RFC] Fix compiler warnings in osabi.c
- References: <200601102222.k0AMMNSq000979@elgar.sibelius.xs4all.nl>
On Tue, Jan 10, 2006 at 11:22:23PM +0100, Mark Kettenis wrote:
> Another GCC 4 warning; e_ident[] is an array of unsigned chars. I
> think the most elegant way to solve this is to use memcmp instead of
> strcmp, since we're comparing a string to what may be random garbage,
> and not two strings.
>
> This one isn't quite so obvious, but if nobody objects, I'll commit
> this after a week.
Yes, looks right to me.
--
Daniel Jacobowitz
CodeSourcery