This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Detect closed file descriptors on Windows


Jim Blandy wrote:
> On 1/11/06, Mark Mitchell <mark@codesourcery.com> wrote:
> 
>>        gdb_assert (!FD_ISSET (fd, writefds));
>>!       if (FD_ISSET (fd, readfds)
>>!         && !FD_ISSET (fd, exceptfds))
>>!       continue;
> 
> 
> Don't you mean, "if (! FD_ISSET (fd, readfds) && ..."?

Definitely.

I got lucky because GDB (at least in simple cases) tends to pass the
same set of descriptors for readfds and exceptfds.

OK with that change?

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]