This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: sim/arm RedBoot meminfo syscall [PATCH]


On Mon, 2006-01-23 at 02:01, Daniel Jacobowitz wrote:
> On Wed, Dec 14, 2005 at 11:40:28AM -0700, Shaun Jackman wrote:
> > This patch implements the RedBoot meminfo syscall. In addition, rather
> > than ignoring unhandled syscalls, it sets errno to ENOSYS and returns
> > -1. This makes it possible to run "Hello, world!" compiled using
> > newlib and a RedBoot libgloss.
> > 
> > Cheers,
> > Shaun
> > 
> > 2005-12-14  Shaun Jackman  <sjackman@gmail.com>
> > 
> > 	* sim/arm/armos.c (ARMul_OSHandleSWI): Handle the RedBoot system
> > 	call meminfo. Return ENOSYS for unhandled RedBoot syscalls.
> 
> This looks totally plausible to me but I don't know much about it;
> Richard, any opinion on it before I approve it?
I've no objections.  The SWI code has already been grabbed, so it
doesn't really extend the interface any further.

As a general principle, however, I'd be against adding more 'top-level'
swi codes without cleaning up the interface to this module so that you
can carefully select from the command line the set of SWIs in force.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]