This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Clean up var_integer/var_uinteger/var_zinteger mess


> X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on 
> 	elgar.sibelius.xs4all.nl
> X-Spam-Level: 
> X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=no 
> 	version=3.1.0
> DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
>         s=beta; d=gmail.com;
>         h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
>         b=TFTIQB+EK02V1vfXwI4QJr/gwBrh3UD5JTREmxEUO/A7bevYVtY02UcXlTjdbxMdWVK0UFIL+7lGFhq9OI4I4ZDiTkjxogv8dHMT4YB0XjPaJwFosrXjv5aSAOTv7blG57qzR2FfqT+q/8wjS018LVkizr+i29iXHZipUDHhXDc=
> Date: Wed, 1 Feb 2006 10:49:22 -0800
> From: Jim Blandy <jimb@red-bean.com>
> Sender: jimblandy@gmail.com
> Cc: gdb-patches@sourceware.org
> Content-Disposition: inline
> X-XS4ALL-DNSBL-Checked: mxdrop24.xs4all.nl checked 64.233.162.193 against DNS blacklists
> X-Virus-Scanned: by XS4ALL Virus Scanner
> X-XS4ALL-Spam-Score: 0 () 
> X-XS4ALL-Spam: NO
> Envelope-To: mark.kettenis@xs4all.nl
> X-MIME-Autoconverted: from quoted-printable to 8bit by mxdrop24.xs4all.nl id k11InHwe077021
> X-UIDL: 1138819766._smtp.mxdrop24.77065,S=2619
> 
> On 2/1/06, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> > Actually, it'd make sense if the existing
> > var_integer/var_uinteger/var_zinteger would accept "unlimited".
> > That'd make your var_limit unnecessary.
> >
> > Does anyone see any problems with that?
> 
> Well, I presume that sometimes (often) those are used for limits of
> something, and sometimes they're genuine integers.  Surely there's
> something in GDB where a negative value would make sense.  I don't
> like the idea of accepting "unlimited" for a quantity that isn't a
> limit on anything.

Well, the current code already prints "unlimited" for
var_integer/var_uinteger.  I'd say it is only logical that they can be
set to "unlimited" too.

Guess your var_zinteger is your "genuine" integer; we probably
shouldn't accept "unlimited" for those.

> Then, of course, there's aix-thread.c which is using zinteger for a boolean.

Of course.  That's the proper type for boolean expressions ;-).

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]