Re: [PATCH] Add fullname field for MI -break-info command

[Vladimir Prus <ghost at cs dot msu dot su>]

Daniel Jacobowitz wrote:

> On Sat, Jan 28, 2006 at 04:09:42PM +0300, Vladimir Prus wrote:
>> Revised patch attached. I did verify that it causes no regressions for MI
>> tests.
>> 
>> 
>> Note, however, that I could not verify that it does not cause any
>> regressions globally, because something seems wrong with my configuration
>> or the test system. Sporadically, I get errors like this:
> 
> What system are you testing on?  Presumably a bug in the host or in the
> port of expect to the host.

(Almost) vanilla Debian Sarge on x86 (dual Xeon). Maybe this can have
something to do with dual-cpu system?

> I've verified no regressions on x86_64-pc-linux-gnu.
> 
> The patch looks OK.  There's a couple of formatting errors, and
> it needs ChangeLog entries, and then it can be applied.
> 
> Oh, and Nick was right: you don't need the loc_type check any more.
> Everything in that case statement will be a breakpoint and have
> a valid address.

OK.

> 
>> +                struct symtab_and_line sal = find_pc_line
>> (b->loc->address, 0);
>> +                char* fullname = symtab_to_fullname (sal.symtab);
> 
> char *fullname, please, for consistency.
> 
>> +                if (fullname)
>> +                  {
>> +                    ui_out_field_string (uiout, "fullname", fullname);
>> +                  }
> 
> Don't need the extra braces here.

Ok.

Revised patch attached.


Changelog entry:

2006-02-02 Vladimir Prus <ghost@cs.msu.su>
        
        * breakpoint.c (print_one_breakpoint): For MI-like UI, output
         'fullname' field.
        * doc/gdb.texinit: Document the 'fullname' field in -break-list
          output.
        * testsuite/gdb.mi/mi-break.exp: Test for the 'fullname' field.
        * testsuite/gdb.mi/mi2-break.exp: Likewise


- Volodya

Attachment: breakpoint_info_fullname.diff
Description: Text document