Re: minimalistic MI catch support

[Daniel Jacobowitz <drow at false dot org>]

On Sat, Jan 28, 2006 at 02:04:24PM +0100, Markus Schiltknecht wrote:
> Hello gdb hackers,
> 
> working on an automated debugging layer on top of gdb I figured the
> catchpoint functions in the MI interface is missing. The attached patch
> against current CVS at least makes gdb report a catchpoint-break via MI.
> This is already sufficient for my application. However, I would
> appreciate a complete catchpoint implementation for the MI interface. I
> haven't figured out how to implement the '-break-catch' command. If
> somebody more knowledgable could do that I'd be thankfull.
> 
> Please CC me in responses, as I'm not subscribed.

Hi Markus,

For the -break-catch command, I recommend you file an issue in our bug
system; that won't help it get done any sooner, but at least it won't
get lost.

For the patch, in general it's better to avoid ui_out_is_mi_like_p when
we can.  Because the text outputs are ignored in non-MI mode, this is
usually pretty easy; see the attached.

This changes from:

*stopped,thread-id="0",frame={addr="0x00002aaaaaeb6462",func="fork",args=[],from="/lib/libc.so.6"}

to:

*stopped,reason="breakpoint-hit",bkptno="1",forked-process="6570",thread-id="0",frame={addr="0x00002aaaaaeb6462",func="fork",args=[],from="/lib/libc.so.6"}

You used fork and vfork for the reasons; I'm not sure whether these
should have separate reasons or be marked as catchpoint-hit.  Bob,
Nick, any opinions on that?

-- 
Daniel Jacobowitz
CodeSourcery

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.221
diff -u -p -r1.221 breakpoint.c
--- breakpoint.c	6 Feb 2006 21:55:05 -0000	1.221
+++ breakpoint.c	6 Feb 2006 23:28:32 -0000
@@ -2167,17 +2167,29 @@ print_it_typical (bpstat bs)
 
     case bp_catch_fork:
       annotate_catchpoint (bs->breakpoint_at->number);
-      printf_filtered (_("\nCatchpoint %d (forked process %d), "),
-		       bs->breakpoint_at->number, 
-		       bs->breakpoint_at->forked_inferior_pid);
+      ui_out_text (uiout, "\nCatchpoint ");
+      if (ui_out_is_mi_like_p (uiout))
+	ui_out_field_string (uiout, "reason",
+			     async_reason_lookup (EXEC_ASYNC_BREAKPOINT_HIT));
+      ui_out_field_int (uiout, "bkptno", bs->breakpoint_at->number);
+      ui_out_text (uiout, " (forked process ");
+      ui_out_field_int (uiout, "forked-process",
+			bs->breakpoint_at->forked_inferior_pid);
+      ui_out_text (uiout, "), ");
       return PRINT_SRC_AND_LOC;
       break;
 
     case bp_catch_vfork:
       annotate_catchpoint (bs->breakpoint_at->number);
-      printf_filtered (_("\nCatchpoint %d (vforked process %d), "),
-		       bs->breakpoint_at->number, 
-		       bs->breakpoint_at->forked_inferior_pid);
+      ui_out_text (uiout, "\nCatchpoint ");
+      if (ui_out_is_mi_like_p (uiout))
+	ui_out_field_string (uiout, "reason",
+			     async_reason_lookup (EXEC_ASYNC_BREAKPOINT_HIT));
+      ui_out_field_int (uiout, "bkptno", bs->breakpoint_at->number);
+      ui_out_text (uiout, " (vforked process ");
+      ui_out_field_int (uiout, "vforked-process",
+			bs->breakpoint_at->forked_inferior_pid);
+      ui_out_text (uiout, "), ");
       return PRINT_SRC_AND_LOC;
       break;