This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: ensure binary objects opened in binary mode

> Date: Fri, 17 Feb 2006 18:41:41 -0500
> From: Christopher Faylor <cgf-please-use-the-mailinglist@sourceware.org>
> 
> On Fri, Feb 17, 2006 at 04:59:27PM -0500, Charles Wilson wrote:
> >2006-02-17  Charles Wilson  <...>
> >
> >	* gdb/solib.c(solib_open): ensure solib files are opened in
> >	binary mode.
> 
> I think this patch is a good idea but I'm wondering if we're doing the
> 
> #ifdef O_BINARY
> # define O_BINARY 0
> #endif
> 
> trick in too many source files.  Maybe it's time for this to be in a header
> file?

Agreed.  I think defs.h is a good place, do you agree?
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]