This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Allow spaces in pathnames to directory command
- From: Daniel Jacobowitz <drow at false dot org>
- To: Andrew STUBBS <andrew dot stubbs at st dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Mon, 20 Feb 2006 14:19:37 -0500
- Subject: Re: [PATCH] Allow spaces in pathnames to directory command
- References: <4395AA58.90505@st.com> <4395AB73.2030704@st.com> <20060220171943.GA19356@nevyn.them.org> <43FA053B.6060502@st.com>
On Mon, Feb 20, 2006 at 06:06:51PM +0000, Andrew STUBBS wrote:
> Daniel Jacobowitz wrote:
> >On Tue, Dec 06, 2005 at 03:17:07PM +0000, Andrew STUBBS wrote:
> >>Andrew Stubbs wrote:
> >>>The directory command and the -d switch do not support pathnames that
> >>>contain spaces.
> >>It looks like my patch ought to fix PR gdb/1832, PR gdb/956, and perhaps
> >>PR gdb/535.
> >
> >Does Andrew's comment about filename_completer in gdb/535 still apply?
>
> Yeah, I suppose it does. Certainly the auto-completer completes names
> with spaces in (provided that the spaces are not in the part already
> typed), but does not add any form of quoting.
>
> It doesn't quote quotes or spaces. Nor does it complete filenames that
> have quoted elements already in them.
>
> This doesn't change the correctness of the patches in question though.
> The bug report gdb/535 complains about the behaviour of generic_load(),
> not the auto-completer - that's a separate issue raised by Andrew Cagney.
>
> I do agree that the completer ought to be fixed at some point.
Except that previously, the filename completer produced things that
were valid for this command, and now it doesn't. Sounds pretty
inconvenient to me.
I bumped up against this separately this morning. I may see about
unifying the completion to handle quoting.
--
Daniel Jacobowitz
CodeSourcery