Re: [PATCH] Allow spaces in pathnames to directory command

[Daniel Jacobowitz <drow at false dot org>]

On Mon, Feb 20, 2006 at 02:19:37PM -0500, Daniel Jacobowitz wrote:
> On Mon, Feb 20, 2006 at 06:06:51PM +0000, Andrew STUBBS wrote:
> > Daniel Jacobowitz wrote:
> > >On Tue, Dec 06, 2005 at 03:17:07PM +0000, Andrew STUBBS wrote:
> > >>Andrew Stubbs wrote:
> > >>>The directory command and the -d switch do not support pathnames that 
> > >>>contain spaces.
> > >>It looks like my patch ought to fix PR gdb/1832, PR gdb/956, and perhaps 
> > >>PR gdb/535.
> > >
> > >Does Andrew's comment about filename_completer in gdb/535 still apply?
> > 
> > Yeah, I suppose it does. Certainly the auto-completer completes names 
> > with spaces in (provided that the spaces are not in the part already 
> > typed), but does not add any form of quoting.
> > 
> > It doesn't quote quotes or spaces. Nor does it complete filenames that 
> > have quoted elements already in them.
> > 
> > This doesn't change the correctness of the patches in question though. 
> > The bug report gdb/535 complains about the behaviour of generic_load(), 
> > not the auto-completer - that's a separate issue raised by Andrew Cagney.
> > 
> > I do agree that the completer ought to be fixed at some point.
> 
> Except that previously, the filename completer produced things that
> were valid for this command, and now it doesn't.  Sounds pretty
> inconvenient to me.
> 
> I bumped up against this separately this morning.  I may see about
> unifying the completion to handle quoting.

Meanwhile, I think that this is a sensible change, so go ahead and
commit it.

The story for quoting arguments passed to MI is very, very confused
right now.  I've just discovered that Eclipse doesn't quote at all,
and doesn't escape backslashes; I'm going to have to dig more, but
I'm going to try to give us a unified picture on this today.

I think that the CLI commands should expect buildargv-style quoting,
and the MI commands should take a more C-style quoting (since that's
how they are documented), but right now I fear they take both.

-- 
Daniel Jacobowitz
CodeSourcery