Re: RFA: ensure binary objects opened in binary mode

[Michael Snyder <msnyder at redhat dot com>]

Eli Zaretskii wrote:
> > Date: Wed, 22 Feb 2006 00:30:46 -0500
> > From: Charles Wilson <cygwin@cwilson.fastmail.fm>
> > CC:  gdb-patches@sourceware.org
> >
> > Okay, I've attached two patches that hopefully address all the issues 
> > raised in this thread.
>
>
> Thanks.
>
>
> > (1) for every file that #includes both defs.h AND <fcntl.h>, remove the 
> > <fcntl.h> inclusion.
>
>
> I'm not sure this is a good idea.  What if tomorrow we remove fcntl.h
> from defs.h--do we go through all these files again and add it back?
> Why bother? fcntl.h should be idempotent, so including it several
> times does no real harm.

It's an extra file open and file read during make.
These things add up.  gdb's include heirarchy is quite
tangled.


> I actually quite dislike source files that don't include standard
> headers because they are included in defs.h and its ilk.  It makes me
> wonder how come foo.c uses something defined in bar.h, but there's no
> "#include <bar.h>" anywhere in sight.

A stylistic question, alas...