This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: Correct "paddr_t" in gdb_proc_service.h


Daniel Jacobowitz wrote:
If there is no <proc_service.h>, GDB will typedef unsigned long to paddr_t,
which is then used in various libthread_db interfaces.  Even when this code
was designed to work on Solaris systems in addition to GNU/Linux, this
wasn't right; Solaris doesn't provide a paddr_t that has anything to do with
libthread_db, only an unrelated one that deals with physical addressing.
The type that glibc's libthread_db uses is psaddr_t, which is a pointer
type.

When I wrote this patch (last year) I went through the original changelog
entries for this file from 2000; they suggest that this change is correct
and there should be no paddr_t references in GDB.

I admit that I can't rememeber now what problem this solved; it may be
nothing, just an inconsistency I noticed while working on N32 support. But I
think it's a worthwhile change to match the prototypes in libthread_db from
whence these functions are called.

Any comments on this change?


Seems ok -- except the cast for target_read_memory should be (CORE_ADDR) addr, n'est ce pas?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]