This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: Start Fortran support for variable objects.
- From: Daniel Jacobowitz <drow at false dot org>
- To: Nick Roberts <nickrob at snap dot net dot nz>
- Cc: Wu Zhou <woodzltc at cn dot ibm dot com>, gdb-patches at sources dot redhat dot com
- Date: Fri, 24 Mar 2006 16:07:18 -0500
- Subject: Re: PATCH: Start Fortran support for variable objects.
- References: <20050630131809.GB8241@nevyn.them.org> <17092.28833.284587.118362@farnswood.snap.net.nz> <Pine.LNX.4.63.0506300455390.11503@wks190384wss.cn.ibm.com> <17092.51062.559020.560618@farnswood.snap.net.nz> <20050703161706.GA13289@nevyn.them.org> <17096.30621.21570.307217@farnswood.snap.net.nz> <20050703234725.GA28151@nevyn.them.org> <17096.37817.638887.840041@farnswood.snap.net.nz> <20050704034904.GA5802@nevyn.them.org> <17428.64494.595245.325277@kahikatea.snap.net.nz>
On Mon, Mar 13, 2006 at 05:58:22PM +1300, Nick Roberts wrote:
> Here's a new patch which does the same as my last one. So the children map as
> before i.e arr.1 == arr(1) because the index for expression "exp" is used to
> compute the "name". However this time I've made changes to c_name_of_child
> and c_value_of_child instead of varobj_list_children, so hopefully you'll find
> it more agreeable.
>
> If I don't change c_name_of_child, I get variable object names like arr.0 as
> you suggest. However, then I also get exp="0" which I use for the index of the
> watch expression. I think this is confusing.
Yeah. If I understand correctly, this patch will name the first
element of the array as var.-1 - is that right?
I think that's OK. However, please add a gdb.mi testcase, and use
temporary variables or wrapping where necessary to avoid the overlong
lines; you added two. If the testcase is a problem let me know and
I'll take care of it.
Thanks for seeing this through!
--
Daniel Jacobowitz
CodeSourcery