This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Start Fortran support for variable objects.


 > My rule for "too long" is "open emacs in an eighty-column terminal, and
 > if it wraps them, they're too long".  The one in c_value_of_child just
 > fits, but the one in c_name_of_child has one too many - emacs
 > starts at column 0, not column 1, 

You're right the lines were 79 and 80 cols wide.

 >                                        so a semicolon in column 79 means
 > that emacs will push the semicolon onto the next line (to have room for
 > the continuation backslash and a space after the cursor).

Not on Emacs 22: the cursor gets pushed into the fringe - anyway I've wrapped
the line, not wishing to appear a sore loser.

 > > FAIL: gdb.mi/mi-file.exp: Getting a list of source files.
 > > FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation
 > > FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation
 > > FAIL: gdb.mi/mi-basics.exp: environment-path dir1 dir2 operation
 > > FAIL: gdb.mi/mi2-basics.exp: environment-directory arg operation
 > > FAIL: gdb.mi/mi2-basics.exp: environment-directory empty-string operation
 > > FAIL: gdb.mi/mi2-basics.exp: environment-path dir1 dir2 operation
 > > 
 > > 
 > > I'm pretty sure the fails have always been there for me.
 > 
 > IIRC the mi-basics failures come from configuring GDB using a relative
 > path.  I don't know the mi-file.exp failure offhand.  But, anyway, this
 > is plenty good.
 > 
 > It's not hard to do this twice, though, so that you know you have no
 > new failures - once with the patch and once without.

OK, I'll remember that.

 > > 2006-03-26  Nick Roberts  <nickrob@snap.net.nz>
 > > 
 > > 	* gdb.mi/mi-var-child-f.exp, gdb.mi/array.f: New files.
 > 
 > Patch is OK with one line wrapped, testcase is OK, thanks a lot!

Comitted.

Nick                                           http://www.inet.net.nz/~nickrob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]