This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove harcoded constants in remote.c:watchpoint_to_Z_packet
- From: Daniel Jacobowitz <drow at false dot org>
- To: Vladimir Prus <ghost at cs dot msu dot su>, gdb-patches at sources dot redhat dot com
- Date: Thu, 30 Mar 2006 11:58:26 -0500
- Subject: Re: [PATCH] Remove harcoded constants in remote.c:watchpoint_to_Z_packet
- References: <200511141308.37238.ghost@cs.msu.su> <20060220174618.GG19356@nevyn.them.org>
On Mon, Feb 20, 2006 at 12:46:18PM -0500, Daniel Jacobowitz wrote:
> On Mon, Nov 14, 2005 at 01:08:36PM +0300, Vladimir Prus wrote:
> >
> > This is a trivial change replacing hardcoded constants with already existing
> > enumerators.
> >
> > Changelog entry:
> >
> > 2005-11-14 Vladimir Prus <ghost@cs.msu.su>
> >
> > * remote.c (watchpoint_to_Z_packet): Use values of Z_packet_type enum
> > instead of hardcoded integer literals.
>
> Sorry, missed this when you posted it. This is fine; do you have
> write access?
>
> ChangeLog formatting, tabs and left column alignment:
>
> * remote.c (watchpoint_to_Z_packet): Use values of Z_packet_type enum
> instead of hardcoded integer literals.
I've belatedly checked this in for Vladimir. Vladimir, I'd suggest you
get write access, but it looks like the copyright paperwork is still up
in the air; we can get you an account once that's done.
--
Daniel Jacobowitz
CodeSourcery