This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] allow nested sourced commands


Michael Snyder wrote:
Hmmm, well, I'm not too familiar with that code, but it looks OK
programatically.  Certainly should be commented better, though,
esp. since a struct called "user_args" now contains something
that's not a user arg.

Ok, fair enough. How about the following inserted into the struct definition:


/* It is necessary to store a malloced copy of the command line to
ensure that the arguments are not overwritten before they are used.  */

Can you add a test in the testsuite?

Yes, I have the test case I posted before. Where would be the correct place to add the test? Just add a new file under gdb.base?


Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]