This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Add 'target |' support for MinGW


Jim Blandy wrote:
On 4/13/06, Eli Zaretskii <eliz@gnu.org> wrote:

Cc: gdb-patches@sources.redhat.com
From: Jim Blandy <jimb@codesourcery.com>
Date: Wed, 12 Apr 2006 11:38:55 -0700


Do we really want binary I/O in _all_ situations?  Can it be that,
depending on the command on the other side of the pipe, someone would
like the CR characters to be stripped from the EOLs in the incoming
stuff?  The way you wrote it, AFAICS, binary I/O is always used, no
matter what.

Well, the pipe is carrying the GDB remote protocol, which is happier with binary.

Do we never ask the remote to list text files, for example?


No, we don't. Text is always encoded in hex, to avoid any munging of
this sort. And for goodness' sake, we wouldn't want line ending
conversion happening magically in the protocol's transport layer! That should be done explicitly in GDB.

Jim's right -- the gdb protocol should be regarded as a binary protocol, even though a lot of it looks like ASCII. We never send text "in the clear". Even when we're simulating stdout, we send the strings encoded. And part of the msg traffic is definitely *not* ascii, so CR/LF conversion would be a very bad thing.





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]