This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [v850 sim] correcting psw flags for divide special cases.
On Fri, Apr 14, 2006 at 04:35:20PM -0400, Daniel Jacobowitz wrote:
> On Thu, Apr 13, 2006 at 07:36:49PM -0400, DJ Delorie wrote:
> >
> > 2006-04-13 DJ Delorie <dj@redhat.com>
> >
> > * simops.c (OP_2C207E0): Correct PSW flags for special divu
> > conditions.
> > (OP_2C007E0): Likewise, for div.
> > (OP_28207E0): Likewise, for divhu.
> > (OP_28007E0): Likewise, for divh.
>
> Hi DJ,
>
> The problem with patches without any human-readable text is we don't
> know what you expect of them... are you asking for approval? If so,
> I'm not sure why, since you're the m32c sim maintainer and few others
> on this list even know what an m32c is. If you're just posting the
> patch as an "FYI, I committed this", then I'd like to point out that
> you didn't commit it :-)
Er, this was a v850 patch, not an m32c patch. D'oh.
Is there anyone out there who can review v850 changes? If not, I
don't see any reason why you shouldn't check them in.
--
Daniel Jacobowitz
CodeSourcery