This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Reverse debugging, part 2/3: core interface
On Thu, Apr 20, 2006 at 12:49:06PM -0700, Michael Snyder wrote:
> Good catch. It should probably be get_frame_pc.
> You agree?
Yep.
> >>+ {
> >>+ /* Set breakpoint and continue. */
> >>+ breakpoint =
> >>+ set_momentary_breakpoint (sal,
> >>+ get_frame_id (get_selected_frame (NULL)),
> >>+ bp_breakpoint);
> >
> >...above you used get_current_frame, here you used get_selected_frame.
> >Which is it? I think that it should be the selected frame in all three
> >cases, by analogy with finish, and there should probably be a similar
> >error for cases without a caller.
>
> Oh man, you're making my head hurt. Which is, I suppose, a good thing.
Only fair, you made my brain ache this morning.
> What's the difference, now? Is 'current_frame' the execution frame,
> and 'selected_frame' the displayed one? (ie. the "up/down" one?)
>
> If that's the case, then I think you're right, it should be
> the selected frame.
That's right.
--
Daniel Jacobowitz
CodeSourcery