This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Can't build ppc32 GDB

On Fri, 2006-05-05 at 22:29 +0200, Mark Kettenis wrote:
> Could you do me a favour, and replace:
> 
>       *(long *) & buf[bytes_transferred]
> 
> with
> 
>       *(long *) &buf[bytes_transferred]
> 
> ?
> 
> That extra space has been there ever since the code was reindented
> using indent(1), but really shouldn't be there.  It makes me think
> it's a bitwise and instead of address off operator.
> 
> Otherwise, yes, ok with that change.
> 
> Mark

OK, committed.   There was another case of *(long *) & buf.... and I
fixed that too.

I also fixed an entry in the ChangeLog that had leading spaces instead
of a tab.

-=# Paul #=-
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]