This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MI: type prefixes for values


> 2006-05-05  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	* valprint.c: Include "exceptions.h".
> 	(val_print): If something goes wrong while printing, supply an
> 	error message.

I have committed this.

On Sat, May 06, 2006 at 09:58:38PM +1200, Nick Roberts wrote:
> It looks like you're catching the error lower down (higher up?)  which allows
> any other values to be printed.  Right?  I like this.

Exactly right - higher up vs lower down is a bit tricky since all of
this stuff is recursive, but probably higher up the call chain.

> > This patch doesn't touch the issue of type prefixes, leaving that to
> > deal with separately.
> 
> If I'm reading this right, I have since realised that my patch to use
> common_val_print was no good because it only prints address and not values for
> things like references

Vladimir noticed that there's a deref_ref argument to common_val_print;
you passed zero, but if you pass one instead, it ought to do the right
thing.

Would you like to try the patch again with that change?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]