This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: AW: AW: [PATCH] source.s: Fix problem handling windows like path with MinGW
> Date: Tue, 20 Jun 2006 16:27:42 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Michael Fischer <fischermi@t-online.de>, gdb-patches@sourceware.org
>
> Personally, I'd grab the #define from libiberty/make-relative-prefix.c,
> and maybe even move it into include/filenames.h. That one's better
> tested. But it uses ';' if _WIN32, so don't ask me how that works for
> Cygwin builds. Maybe it doesn't.
>
> I'm fine with Chris's suggested definition, naturally.
Thanks to you and Chris for all the feedback.
I eventually opted for the change in defs.h, to avoid the risk of
breaking something else that uses include/filenames.h. Here's what I
actually committed:
2006-06-24 Eli Zaretskii <eliz@gnu.org>
* defs.h (DIRNAME_SEPARATOR) [!__CYGWIN__ && _WIN32]: Define to `;'.
Index: gdb/defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.194
diff -u -r1.194 defs.h
--- gdb/defs.h 25 Feb 2006 04:36:39 -0000 1.194
+++ gdb/defs.h 24 Jun 2006 13:47:43 -0000
@@ -1163,6 +1163,10 @@
# define DIRNAME_SEPARATOR ';'
#endif
+#if !defined (__CYGWIN__) && defined (_WIN32)
+# define DIRNAME_SEPARATOR ';'
+#endif
+
#ifndef DIRNAME_SEPARATOR
#define DIRNAME_SEPARATOR ':'
#endif