This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fixes problem setting breakpoint in dynamic loader
- From: Daniel Jacobowitz <drow at false dot org>
- To: PAUL GILLIAM <pgilliam at us dot ibm dot com>
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sources dot redhat dot com
- Date: Wed, 5 Jul 2006 22:57:12 -0400
- Subject: Re: [patch] Fixes problem setting breakpoint in dynamic loader
- References: <1148513171.315.104.camel@dufur.beaverton.ibm.com> <200606172021.k5HKL82O013629@elgar.sibelius.xs4all.nl> <1152143843.6282.49.camel@dufur.beaverton.ibm.com>
Formatting notes.
On Wed, Jul 05, 2006 at 04:57:23PM -0700, PAUL GILLIAM wrote:
> + contain executable code and we can set a breakpoint there. */
Two spaces after period, here and elsewhere.
> + /* No symbol was found in a code section, so look elsewhere. */
> + for (bkpt_namep = solib_break_names; *bkpt_namep!=NULL; bkpt_namep++)
Line is too long; also related, spaces around operators.
> + /* On ABI's that use function descriptors that are in the data
> + section, */
Lost a bit of this comment?
--
Daniel Jacobowitz
CodeSourcery