This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] clean up two alpha deprecateds
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: rth at twiddle dot net
- Cc: gdb-patches at gcc dot gnu dot org
- Date: Sat, 8 Jul 2006 01:40:37 +0200 (CEST)
- Subject: Re: [PATCH] clean up two alpha deprecateds
- References: <20060630005714.GA29142@twiddle.net>
> Date: Thu, 29 Jun 2006 17:57:14 -0700
> From: Richard Henderson <rth@twiddle.net>
>
> As far as I can tell, alpha_register_byte did nothing useful anymore.
> Leastwise I can't see any effect simply from removing it and its
> depricated hook.
>
> Changing to alpha_return_value is a teeny bit trickier, since we
> really did like the old use_struct_convention hook for the one
> abberant alpha abi. I've moved that to a hook in the tdep structure
> instead. I copied the rest of the form of alpha_return_value from
> the i386 port.
Cool. Someone sent me an alpha recently, so I've tested this on
OpenBSD/alpha, and I didn't see any regressions.
> I do note that the i386 port does nothing for writeval for structures;
> I'm not sure why that would be correct, but I've duplicated it.
Basically, given the fact that the function returns
RETURN_VALUE_ABI_RETURNS_ADDRESS means that it will never be called
with a non-NULL writebuf.
Anyway, the implemenattaion looks sane to me, so please go ahead and
commit.
Mark
> 2006-06-29 Richard Henderson <rth@redhat.com>
>
> * alpha-tdep.h (struct gdbarch_tdep): Add return_in_memory.
> * alpha-tdep.c (alpha_register_byte): Remove.
> (alpha_extract_struct_value_address): Remove.
> (alpha_return_value): New.
> (alpha_return_in_memory_always): New.
> (alpha_gdbarch_init): Set tdep->return_in_memory. Don't call
> set_gdbarch_deprecated_register_byte. Do call set_gdbarch_return_value
> instead of set_gdbarch_deprecated_use_struct_convention,
> set_gdbarch_extract_return_value, set_gdbarch_store_return_value,
> or set_gdbarch_deprecated_extract_struct_value_address.
> * alphafbsd-tdep.c (alphafbsd_return_in_memory): Rename from
> alphafbsd_use_struct_convention, remove gcc_p argument.
> (alphafbsd_init_abi): Set tdep->return_in_memory instead of
> set_gdbarch_deprecated_use_struct_convention.