This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: -stack-list-frames HIGH_FRAME changes


> From: Vladimir Prus <ghost@cs.msu.su>
> Date: Fri, 8 Sep 2006 10:27:50 +0400
> Cc: gdb-patches@sources.redhat.com
> 
> ./Changelog:
> 2006-05-05  Vladimir Prus  <ghost@lvk.cs.msu.su>
> 
>         * mi/mi-cmd-stack.c (mi_cmd_stack_list_args): Don't emit error
>         if high requested frame number is larger then number of available 
>         frames.                                  ^^^^
> 
> 
> doc/ChangeLog
> 2006-05-05  Vladimir Prus  <ghost@lvk.cs.msu.su>
> 
>         * gdb.texinfo (GDB/MI Stack Manipulation): Mention that
>         -stack-list-arguments HIGH_FRAME argument can be larger then the
>         actual number of frames.                                ^^^^

You mean "than", not "then".

>  Display a list of the arguments for the frames between @var{low-frame}
>  and @var{high-frame} (inclusive).  If @var{low-frame} and
> -@var{high-frame} are not provided, list the arguments for the whole call
> -stack.
> +@var{high-frame} are not provided, list the arguments for the whole
> +call stack. If the two arguments are equal, it shows the single frame
             ^^
Two spaces, please.

Also, ``it shows'' is not in line with the style of the rest of the
description; ``show'' is better:

  If the two arguments are equal, show the single frame at the
  given level.

> +larger than the actual number of frames.  On the other hand,
> +@var{high-frame} may be larger then the actual number of frames, in
                                  ^^^^
"than".

With these fixes, you have green light to commit the patch.  Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]