This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Use vec.h to revise memattr.[ch]
- From: Daniel Jacobowitz <drow at false dot org>
- To: gdb-patches at sourceware dot org
- Date: Thu, 21 Sep 2006 09:50:14 -0400
- Subject: Re: [rfc] Use vec.h to revise memattr.[ch]
- References: <20060815193017.GB29509@nevyn.them.org>
On Tue, Aug 15, 2006 at 03:30:17PM -0400, Daniel Jacobowitz wrote:
> Any comments? I think it's a net improvement in clarity.
There weren't any :-) The long delay on these flash support patches,
if you are wondering, was while we shook the bugs out of our own stub
implementation and tested both that and the GDB patches; at this
point, I believe what we have is quite solid.
> 2006-08-15 Daniel Jacobowitz <dan@codesourcery.com>
>
> * Makefile.in (memattr_h, memattr.o): Update.
> * memattr.h: Include "vec.h".
> (struct mem_region): Remove linked list pointer.
> (mem_region_s): New typedef and corresponding vector.
> * memattr.c: Include "vec.h".
> (mem_region_chain): Delete.
> (mem_region_list): New vector pointer.
> (mem_region_lessthan): New function.
> (create_mem_region): Remove unused return value. Use vector
> operations. Remove linear search.
> (delete_mem_region): Delete.
> (lookup_mem_region): Use vector operations. Add a FIXME.
> (mem_info_command): Update to work with vectors.
> (mem_enable, mem_enable_command, mem_disable, mem_disable_command)
> (mem_free, mem_delete): Likewise.
Tested on x86_64-pc-linux-gnu, and checked in.
--
Daniel Jacobowitz
CodeSourcery