This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] realloc bug in add_symbol_file_command


On Fri, 2006-10-06 at 23:57 +0200, Jean-Marc Saffroy wrote:
> On Fri, 6 Oct 2006, Michael Snyder wrote:
> 
> > On Fri, 2006-10-06 at 16:16 +0200, Jean-Marc Saffroy wrote:
> >> Hello,
> >>
> >> In gdb 6.5 I had systematic crashes with add-symbol-file: my kernel
> >> modules have many sections... :) The patch below lets me load many modules
> >> now.
> >
> > Just to be safe, might you want to use >=?
> 
> Do you fear the processor would skip a number when incrementing the 
> variable indexing the section array? ;-)

Yes.  I'm just paranoid that way.   ;-)

> Given the current code, it should not be necessary in any way, but feel 
> free to change the patch as you please.

It was just a suggestion, not a demand.

Anyway, I was going to approve your change, but I see that it's
already in.  Andreas Schwab anticipated you on August 24.   
Great minds think alike.  ;-)



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]