This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't give spurious warnings when using thread specific breakpoints

On Wed, Oct 18, 2006 at 01:01:23PM +0100, Andrew STUBBS wrote:
> How about the attached patch which includes the one without the other? 
> I've also taken the opportunity to add _() macros to a few strings.

Except that they're not useful that way :-(  This should always be a
red flag:

> -			       : ((others == 1) ? " and" : ""));
> +			       : ((others == 1) ? _(" and") : ""));

There's no useful translation for " and".  If you can't group the
translatable bits into whole messages, you're pretty much stuck.
Maybe Eli will have a suggestion on how to properly mark up this.

Aside from the i18n issues, this patch looks reasonable to me.


-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]