This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Replace deprecated_target_new_objfile_hook by observer?
Ulrich,
> To fix this, I'm currently using this patch, which attempts to express
> more directly that linux-thread-db should not be used if the target is
> remote:
Would you mind submitting your change for inclusion? I could then
leverage off of this change for the transition to observers.
Thanks!
>
> diff -urN gdb-orig/gdb/linux-thread-db.c gdb-6.5/gdb/linux-thread-db.c
> --- gdb-orig/gdb/linux-thread-db.c 2006-05-06 00:42:43.000000000 +0200
> +++ gdb-6.5/gdb/linux-thread-db.c 2006-09-25 02:12:11.382901136 +0200
> @@ -669,6 +669,10 @@
> if (!target_has_execution)
> return;
>
> + /* Don't attempt to use thread_db for remote targets. */
> + if (!target_can_run (¤t_target))
> + return;
> +
> /* Initialize the structure that identifies the child process. */
> proc_handle.pid = GET_PID (inferior_ptid);
>
> diff -urN gdb-orig/gdb/remote.c gdb-6.5/gdb/remote.c
> --- gdb-orig/gdb/remote.c 2006-05-05 22:08:45.000000000 +0200
> +++ gdb-6.5/gdb/remote.c 2006-09-25 02:12:11.449890952 +0200
> @@ -5466,8 +5466,7 @@
> remote_check_symbols (objfile);
> }
> /* Call predecessor on chain, if any. */
> - if (remote_new_objfile_chain != 0 &&
> - remote_desc == 0)
> + if (remote_new_objfile_chain)
> remote_new_objfile_chain (objfile);
> }
>
> Does this look reasonable?
>
> Bye,
> Ulrich
>
> --
> Dr. Ulrich Weigand
> Linux on zSeries Development
> Ulrich.Weigand@de.ibm.com
--
Joel