Re: Xtensa GDB port -- revised patch

[Maxim Grigoriev <maxim at tensilica dot com>]

Hi Daniel,

Thank you very much for finding the time to review Xtensa submission.
>   - The port needs a maintainer, and an entry in MAINTAINERS.  Who will
>     be the maintainer?
>   
I'd be happy to become an Xtensa GDB maintainer.

I have a question about the second issue you pointed to:
>   - I noticed that your prev_register recursively calls
>     frame_register_unwind.  This isn't a big problem but it is
>     incorrect.  If you defer to another frame, you should set
>     e.g. realnump to point the number for the next frame.  See
>     trad_frame_get_prev_register for an example.
>   
I understood your concern is that the register number within the next 
frame is not set ( *realnump ). On Xtensa, it's going to be unchanged 
from the previous frame's value.

Question: is replacing of

frame_register_unwind (next_frame, regnum,
optimizedp, lvalp, addrp, realnump, valuep);

with

*optimizedp = 0;
*lvalp = lval_register;
*addrp = 0;
*realnump = regnum;
if (valuep)
frame_unwind_register (next_frame, (*realnump), valuep);

the fix you are looking for ? I tested it. It works fine.

And, I fixed the rest of issues ( sorry for missing that ) :
>   - There's one stray hunk:
>   
> > @@ -1330,7 +1332,6 @@
> >  	done
> >  
> >  Makefile: Makefile.in config.status @frags@
> > -	# Regenerate the Makefile and the tm.h / nm.h links.
> >  	CONFIG_FILES=Makefile \
> >     
>   - There's a few instances of operators without spaces around them,
>     like "-=4" and "(op1)==0x6c" and "8? 8".  I don't think you need to
>     go back and fix them at this point, but please be careful in the
>     future.
>   
-- Maxim